sync up react_state's return type #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouldn't matter, but this makes it consistent
maxpkatz
reviewed
Sep 21, 2023
maxpkatz
reviewed
Sep 23, 2023
Source/reactions/Castro_react.cpp
Outdated
| } else { | ||
| return false; | ||
| } | ||
| return burn_success == 1; |
There was a problem hiding this comment.
Now that the return type is int, can we just return burn_success?
maxpkatz
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
We had the return type as
bool, but were returning anint. This shouldn't matter,but this makes it consistent.
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate