fix some warnings from clang-tidy in the MOL code

AMReX-Astro · Aug 31, 2023 · c3594ef · c3594ef
1 parent f1b93be
commit c3594ef
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/Exec/reacting_tests/bubble_convergence/problem_initialize_state_data.H b/Exec/reacting_tests/bubble_convergence/problem_initialize_state_data.H
@@ -12,8 +12,6 @@ void problem_initialize_state_data (int i, int j, int k,
                                     Array4<Real> const& state,
                                     const GeometryData& geomdata)
 {
-    int coord_type = geomdata.Coord();
-
     const Real* dx = geomdata.CellSize();
     const Real* problo = geomdata.ProbLo();
 

diff --git a/Source/hydro/Castro_mol_hydro.cpp b/Source/hydro/Castro_mol_hydro.cpp
@@ -36,8 +36,6 @@ Castro::construct_mol_hydro_source(Real time, Real dt, MultiFab& A_update)
   }
 
 
-  const Real *dx = geom.CellSize();
-
   MultiFab& S_new = get_new_data(State_Type);
 
   int coord = geom.Coord();
@@ -560,21 +558,21 @@ Castro::construct_mol_hydro_source(Real time, Real dt, MultiFab& A_update)
                                        });
             } // end do_hydro
 
+#ifdef DIFFUSION
             // add a diffusive flux
             cond.resize(obx, 1);
             Elixir elix_cond = cond.elixir();
             auto cond_arr = cond.array();
 
-#ifdef DIFFUSION
             fill_temp_cond(obx, Sborder.array(mfi), cond_arr);
 
             const Box& nbx = amrex::surroundingNodes(bx, idir);
 
             mol_diffusive_flux(nbx, idir,
                                uin_arr, cond_arr,
                                flux[idir].array());
-
 #endif
+
           } // end idir loop
 
 #ifndef AMREX_USE_GPU

diff --git a/Source/hydro/fourth_center_average.H b/Source/hydro/fourth_center_average.H
@@ -1,5 +1,5 @@
-#ifndef _FOURTH_CENTER_AVERAGE_H_
-#define _FOURTH_CENTER_AVERAGE_H_
+#ifndef FOURTH_CENTER_AVERAGE_H
+#define FOURTH_CENTER_AVERAGE_H
 
 AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE
 Real