Work in Progress #467
Closed
Work in Progress #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add print function to collections * Make the IReader interface capable of jumping to events * Split python parts into its own shared lib * Make it possible to read SIO files via python * Add podio-dump tool to inspect podio files Make sure print flushes the stream to ensure that python and c++ stdout are "synchronized" * Make podio-dump also dump event data
* PodioConfig: set ENABLE_SIO variable to avoid warning about cmake policy CMP0012 in downstream packages * CMake: Explicitly require version 3 (or newer) for Catch2
* Use latest versions of actions and introduce log groups * Update to LCG_102 in test lcg based environments * Add workflow that builds EDM4hep after podio
* Make python code a proper module * Reorganize CMake config for shared libraries * Refactor library and dict generation in cmake config * Add basic version of python bindings for working with Frames
* Lift an existing root and sio legacy frame reader from git * Add python bindings for legacy readers
* Add dumping functionality for Frames * Add a few basic tests for podio-dump
…IDASoft#351) * Fix erroneously considering empty collections as not present * Handle missing SIO backend more gracefully in podio-dump
…#354) * Add /include to ROOT_INCLUDE_PATH
Necessary for podio-dump
* Fix README with the new path * Use the choices from argparse for the handlers
* Initialize unique_ptr in initializer list for nvcc * Skip tests for podio build in edm4hep workflows Co-authored-by: Valentin Volkl <[email protected]>
* Add a RNTuple writer * Cleanup and add a reader * Add compilation instructions for RNTuple * Add tests * Fix the reader and writer so that they pass most of the tests * Commit missing changes in the header * Add support for Generic Parameters * Add an ugly workaround to the unique_ptr issue * Read also vector members and remove some comments * Do a bit of cleanup * Do more cleanup, also compiler warnings * Add names in rootUtils.h, fix a few compiler warnings * Add a few minor changes * Add missing changes in the headers * Change map -> unordered_map and use append in CMakeLists.txt * Simplify writing and reading of generic parameters * Only create the ID table once * Add CollectionInfo structs * Add a ROOT version check * Add missing endif() * Add Name at the end of some names * Add missing Name at the end * Cast to rvalue * Cache entries and reserve * Add comment and remove old comments * Remove a few couts * Remove intermediate variables and use std::move * Run clang-format * Use clang-format on tests too * Enable RNTuple I/O in Key4hep CI * Check if dev3 workflows come with recent enough ROOT * Change MakeField to the new signature * Update the RNTuple reader and writer to use the buffer factory * Run clang-format * Update the RNTuple writer to use a bare model * Add friends for Generic Parameters * Update changes after the changes in the collectionID and string_view * Run clang-format * Update the reader and writer to conform to AIDASoft#405 * Reorganize and clean up code in the reader * Run clang-format * Simplify how the references are filled --------- Co-authored-by: jmcarcell <[email protected]> Co-authored-by: tmadlener <[email protected]>
Co-authored-by: jmcarcell <[email protected]>
* Switch to a newer LCG stack with root 6.28/00 * Try with key4hep nightlies * Allow git to run necessary commands for pre-commit * Fix clang-format complaints * Fix clang-tidy complaints * Reorder some imports to make pylint happy again * Enbale building RNTuple support in more workflows
Co-authored-by: jmcarcell <[email protected]>
Co-authored-by: jmcarcell <[email protected]>
…DASoft#461) * Add v00-16-06 test files * Make the reader read v00-16-06 files correctly * Bump patch version to 99 for development
* Add put method to Frame python bindings * Add a test that writes a file via the python bindings and ROOT * Add a c++ test that reads content written in python * Add a put_parameter method to the python Frame
* Add tests that reproduce crash / failure * Only recast vector members for non-subset collections * Only read / write vector member buffers if they exist with SIO * Make pyton tests aware of new collection * [format] flake8 fixes * Fix typo in test output * Cleanup unittests * Actually populate an empty test section * Add a test case show-casing the failure * Make sure to only access vector members if available * Add tests read and write tests for SIO * Add I/O tests to ignore list for sanitizer builds
Rebased master branch with julia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed:
‘.jl’file, which was caused by an empty namespace. Moving forward, the file will be named as‘<package_name>.jl’.ParentModule.jl.jinja2template by utilizing thepackage_nameas the module name.Constructor.jl.jinja2template to include default parameters in the constructors.