Skip to content

Commit

Permalink
Remove some includes and fix a couple of URLs (#696)
Browse files Browse the repository at this point in the history
Co-authored-by: jmcarcell <[email protected]>
  • Loading branch information
jmcarcell and jmcarcell authored Oct 17, 2024
1 parent f9edb76 commit 87e0fee
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion include/podio/CollectionBuffers.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ struct CollectionReadBuffers {
// field again.
RecastFuncT recast{};

// Workaround for https://github.com/AIDASoft/podio#500
// Workaround for https://github.com/AIDASoft/podio/issues/500
// We need a function that explicitly deletes the buffers, but for this we
// need type information, so we attach a delete function at generation time
DeleteFuncT deleteBuffers{};
Expand Down
3 changes: 0 additions & 3 deletions podioVersion.in.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
#include <ostream>
#include <sstream>
#include <tuple>
#if __cplusplus >= 202002L
#include <compare>
#endif

// Some preprocessor constants and macros for the use cases where they might be
// necessary
Expand Down
2 changes: 1 addition & 1 deletion src/ROOTFrameData.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ROOTFrameData::ROOTFrameData(BufferMap&& buffers, CollIDPtr&& idTable, podio::Ge
m_buffers(std::move(buffers)), m_idTable(std::move(idTable)), m_parameters(std::move(params)) {
}

// Interim workaround for https://github.com/AIDASoft/podio#500
// Interim workaround for https://github.com/AIDASoft/podio/issues/500
ROOTFrameData::~ROOTFrameData() {
for (auto& [_, buffer] : m_buffers) {
buffer.deleteBuffers(buffer);
Expand Down
2 changes: 0 additions & 2 deletions tests/write_frame.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@
#include "podio/Frame.h"
#include "podio/LinkCollection.h"
#include "podio/UserDataCollection.h"
#include "podio/utilities/TypeHelpers.h"

#include <string>
#include <tuple>
#include <type_traits>

auto createMCCollection() {
auto mcps = ExampleMCCollection();
Expand Down

0 comments on commit 87e0fee

Please sign in to comment.