Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditions: use static unsigned long long int because ROOTs latest ll… #1331

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

andresailer
Copy link
Member

…vm otherwise causes assertion in debug mode about not being able to represent in 64 bit.
(Not sure if bug in enum parsing???)

Otherwise this error shows up when ROOT is in debug mode

python -c "import DDG4"
python: /build/jenkins/workspace/lcg_nightly_pipeline/build/projects/ROOT-HEAD/src/ROOT/HEAD/interpreter/llvm-project/llvm/include/llvm/ADT/APSInt.h:99: int64_t llvm::APSInt::getExtValue() const: Assertion `isRepresentableByInt64() && "Too many bits for int64_t"' failed.

BEGINRELEASENOTES

  • Conditions: change FIRST_KEY, LAST_KEY to constexpr instead of anonymous enum

ENDRELEASENOTES

…vm otherwise causes assertion in debug mode about not being able to represent in 64 bit. Not sure if bug in enum parsing???
Copy link
Contributor

@MarkusFrankATcernch MarkusFrankATcernch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from the C++ side should not be noticeable, since the enum is anonymous.
Go along with it.

Maybe we should start to replace the enums consistently with "static constexpr ...."?
I do not know.

@andresailer
Copy link
Member Author

Thanks for the review @MarkusFrankATcernch !

I think, only change things if we have to!

Copy link

Test Results

   11 files     11 suites   6h 21m 48s ⏱️
  366 tests   165 ✅ 0 💤 201 ❌
1 506 runs  1 301 ✅ 0 💤 205 ❌

For more details on these failures, see this check.

Results for commit 7ae083d.

@andresailer andresailer merged commit 3e720be into AIDASoft:master Oct 16, 2024
9 of 14 checks passed
@andresailer andresailer deleted the enumUll branch October 16, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants