Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow finding newer versions of podio (for EDM4hep IO) #1280

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 21, 2024

After podio changed to 1.0.0 (see AIDASoft/podio@072c7dc), cmake won't run when asking for version 0.16.3. I think we can remove the requirement and let the build systems figure which versions are compatible with which.

The error when configuring is:

  >> 61    CMake Error at CMakeLists.txt:158 (find_package):
     62      Could not find a configuration file for package "podio" that is co
           mpatible
     63      with requested version "0.16.3".
     64    
     65      The following configuration files were considered but not accepted
           :
     66    
     67        /cvmfs/sw-nightlies.hsf.org/key4hep/releases/2024-06-21/x86_64-a
           lmalinux9-gcc11.4.1-opt/podio/072c7dce699a2dc90f225cb0a75a4f2ce9677c
           f8_develop-52hwbt/lib64/cmake/podio/podioConfig.cmake, version: 1.0.
           0

BEGINRELEASENOTES

  • CMake: Allow finding version 1.0 (and newer) for podio

ENDRELEASENOTES

Copy link

github-actions bot commented Jun 21, 2024

Test Results

   14 files     14 suites   6h 50m 55s ⏱️
  363 tests   363 ✅ 0 💤 0 ❌
2 496 runs  2 496 ✅ 0 💤 0 ❌

Results for commit 8b8735e.

♻️ This comment has been updated with latest results.

@wdconinc
Copy link
Contributor

I disagree with this approach of removing dependency version information. DD4hep requires a certain set of podio features, namely those provided by 0.16.3. Podio promises (through the SameMajorVersion policy) that any newer version with same major version can be expected to provide those features, but a different major version does not come with that promise. Failing on build configuration when you attempt to use podio 1.0.0 is exactly what should happen here.

Podio could change the policy to AnyNewerVersion (which then essentially means that you cannot use major version updates to remove API functionality).

CMakeLists.txt Outdated Show resolved Hide resolved
@andresailer
Copy link
Member

Can someone remind me again, why we search explicitly for podio and not just EDM4hep here?

@wdconinc
Copy link
Contributor

Can someone remind me again, why we search explicitly for podio and not just EDM4hep here?

This is because of the need for podio::Frame support (57a7bf2), which EDM4hep separately doesn't care about.

@andresailer andresailer enabled auto-merge (rebase) June 24, 2024 13:51
@andresailer andresailer changed the title Remove the version in find_package(podio) Allow finding newer versions of podio (for EDM4hep IO) Jun 24, 2024
@andresailer andresailer merged commit f3304b4 into AIDASoft:master Jun 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants