-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data extension class for FCCee Drift Chamber #1253
Add data extension class for FCCee Drift Chamber #1253
Conversation
@atolosadelgado given the nature of these changes: |
Test Results 14 files 14 suites 8h 15m 5s ⏱️ Results for commit 3a2f5c2. ♻️ This comment has been updated with latest results. |
d777489
to
edef9b1
Compare
edef9b1
to
20db18f
Compare
Hi, I have moved the data extension to a dedicated file. The class is header only. I noticed that for the other data extensions a dictionary is created here, do I have to create the dictionary as well? Why a dictionary is needed? Thank you for your time :) |
thanks @andresailer for the comments! |
Brieuc wanted me to add another functionality to the class, I hope I can implemented it today, please do not merge it yet :) |
We will keep the functionality where it is needed now. If in the future it is needed in more places we can upstream it here. Please review and merge at your earliest convenience :) |
Hi,
I went for the option of using a data extension for the drift chamber detector to store the parameters needed to later build the geometry and provide some functionalities as well. It seems these data and functionalities are useful at other stages (digitization and reconstruction).
I have developed the data extension class as part of the geometry within the k4geo repository, link, but I thought it could be useful to upstream it to DD4hep. What do you think?
BEGINRELEASENOTES
ENDRELEASENOTES