Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDisplay: RGeomViewer is no longer experimental #1162

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

andresailer
Copy link
Member

LCG nightly builds:

/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDEve/root7/WebDisplay.cpp:22:41: error: 'RGeomViewer' in namespace 'ROOT::Experimental' does not name a type
   22 | using GEOM_VIEWER = ROOT::Experimental::RGeomViewer;
      |                                         ^~~~~~~~~~~
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDEve/root7/WebDisplay.cpp: In function 'long int webdisplay(dd4hep::Detector&, int, char**)':
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDEve/root7/WebDisplay.cpp:84:36: error: 'GEOM_VIEWER' was not declared in this scope
   84 |     auto viewer = std::make_shared<GEOM_VIEWER>(&mgr);
      |                                    ^~~~~~~~~~~
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/DD4hep-master/src/DD4hep/master/DDEve/root7/WebDisplay.cpp:84:48: error: no matching function for call to 'make_shared<<expression error> >(TGeoManager*)'
   84 |     auto viewer = std::make_shared<GEOM_VIEWER>(&mgr);

BEGINRELEASENOTES

  • DDEve Webdisplay: fix issue with ROOT master with RGeomViewer no longer being in the experimental namespace.

ENDRELEASENOTES

@andresailer andresailer enabled auto-merge (rebase) August 25, 2023 11:34
@github-actions
Copy link

Test Results

    4 files      4 suites   4h 32m 21s ⏱️
355 tests 355 ✔️ 0 💤 0
705 runs  705 ✔️ 0 💤 0

Results for commit 8952545.

@andresailer
Copy link
Member Author

dev3 tests are failing because that still has the ROOT from yesterday, but root-project/root#13510 was merged yesterday, so we are failing to compile DD4hep in the dev3 nightlies. Merging this PR and tomorrow the tests should work again.

@andresailer andresailer merged commit 8715c52 into AIDASoft:master Aug 25, 2023
12 of 14 checks passed
@andresailer andresailer deleted the fixWebDisplay branch August 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant