transaction result status optimization, clear return the expired desc…

…ription
AElfProject · Nov 13, 2024 · 1e7c987 · 1e7c987
1 parent 88d4e10
commit 1e7c987
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/protobuf/aelf/core.proto b/protobuf/aelf/core.proto
@@ -59,6 +59,8 @@ enum TransactionResultStatus {
     PENDING_VALIDATION = 5;
     // Transaction validation failed.
     NODE_VALIDATION_FAILED = 6;
+    // Transaction is expired and will never succeed
+    EXPIRED = 7;
 }
 
 message TransactionResult {

diff --git a/src/AElf.WebApp.Application.Chain/Services/TransactionResultAppService.cs b/src/AElf.WebApp.Application.Chain/Services/TransactionResultAppService.cs
@@ -118,9 +118,16 @@ await _transactionResultProxyService.InvalidTransactionResultService.GetInvalidT
                 return output;
             }
         }
-
-        return output;
 
+        switch (output.BlockNumber - output.Transaction.RefBlockNumber)
+        {
+            case > KernelConstants.ReferenceBlockValidPeriod:
+                output.Status = TransactionResultStatus.Expired.ToString().ToUpper();
+                output.Error = TransactionErrorResolver.TakeErrorMessage(TransactionResultStatus.Expired.ToString(), _webAppOptions.IsDebugMode);
+                return output;
+            default:
+                return output;
+        }
     }
 
     /// <summary>