Improve acs3 protocol #34
sonarqube.yaml
on: pull_request
static-code-analysis
7m 22s
Annotations
12 warnings
static-code-analysis
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-java@v1, actions/cache@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
static-code-analysis
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
static-code-analysis
Import cross_chain_contract.proto is unused.
|
static-code-analysis:
src/AElf.Runtime.CSharp.Core/SdkStreamManager.cs#L20
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
static-code-analysis:
src/AElf.Core/CoreAElfModule.cs#L34
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
static-code-analysis:
src/AElf.Core/ITaskQueue.cs#L92
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
|
static-code-analysis:
src/AElf.Core/ITaskQueue.cs#L23
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
|
static-code-analysis:
src/AElf.Core/CoreAElfModule.cs#L43
'T' is not used in the class. (https://rules.sonarsource.com/csharp/RSPEC-2326)
|
static-code-analysis:
src/AElf.Core/CoreAElfModule.cs#L39
Add the 'out' keyword to parameter 'T' to make it 'covariant'. (https://rules.sonarsource.com/csharp/RSPEC-3246)
|
static-code-analysis:
src/AElf.Core/ITaskQueue.cs#L122
Add the default parameter value defined in the overridden method. (https://rules.sonarsource.com/csharp/RSPEC-1006)
|
static-code-analysis:
src/AElf.Core/AElfDefaultConventionalRegistrar.cs#L26
Merge this if statement with the enclosing one. (https://rules.sonarsource.com/csharp/RSPEC-1066)
|
static-code-analysis:
src/AElf.Core/AElfDefaultConventionalRegistrar.cs#L25
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
|