Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ACT_GMOD_SIT_ROLLERCOASTER with ACT_HL2MP_SIT animation on playerstart chairs #382

Merged

Conversation

sigurdjoergensen
Copy link
Contributor

Replaces the rollercoaster animation of playerstart chairs with the HL2MP_SIT animation. This makes the playermodel actually stay inside the hitbox and avoids hands and feet sticking out from the armor. The chairs without rollercoaster animation are left alone. It's done in the same way as Garry's Mod does it: https://github.com/Facepunch/garrysmod/blob/master/garrysmod/lua/autorun/base_vehicles.lua

@sigurdjoergensen
Copy link
Contributor Author

image
new problem, characters are sitting a bit above the hitbox. i dont know if this is worse or can be easily fixed

@sigurdjoergensen
Copy link
Contributor Author

image
I tried the vehicle_feet_passenger of the model but this breaks the physics completely, i give up B-)

@TwistedTail
Copy link
Member

So far, I can't seem to find any built-in way to move the driver around. The only option in this case would be manually moving around the player after they enter the seat (Unparent, move, parent), but I assume that will have other complications arise. Personally I don't think it's worth the effort.

@sigurdjoergensen
Copy link
Contributor Author

I moved the position of the playermodel by changing the vehicle_feet_passenger0 attachment in the decompiled models coordinate from 20 to 17 in the up down axis, and to fix the collison model being rotated from the actual visual model, i just kept old physics model as it breaks on compilation for some reason. The player model is still slighly misaligned from the wireframe, but thats because of the pose itself and the entire chair model would have to be changed to fix that. here are pictures:
hl2_6Nyxy9874W
hl2_wu7ZGQHPLO

@thecraftianman
Copy link
Member

Could you remove the conflicting model files from this?

@TwistedTail
Copy link
Member

Could you remove the conflicting model files from this?

@sigurdjoergensen This is pretty much the only thing required to have this PR approved and merged.

@sigurdjoergensen
Copy link
Contributor Author

sigurdjoergensen commented Apr 14, 2024

Was this what you wanted?
Do mind that the player alignment with hitbox might be kind of shit

@TwistedTail TwistedTail merged commit 00927ed into ACF-Team:master Apr 17, 2024
2 checks passed
@sigurdjoergensen sigurdjoergensen deleted the sigurdjoergensen-patch-1 branch July 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants