forked from FAIR-Chem/fairchem
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MACE #1
Draft
abhshkdz
wants to merge
40
commits into
main
Choose a base branch
from
mace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/target edge weights, multiple convs, identity skip block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, here's an initial attempt at integrating the MACE model into the OCP codebase.
Checklist of some of the code changes and details we discussed:
amsgrad = True
, sweeping overinitial_lr = [1.e-2, 5.e-3, 1.e-3]
normalize_labels
since theScaleShiftBlock
in MACE model does the same thing.1.e-10
or lower.On code organization, I've tried to use as much of
ACEsuit/mace-core
as possible, but there's still quite a bit of duplication between this andACEsuit/mace
, which is non-ideal. Let me know if you guys have thoughts on how to better organize this and/or feel free to directly push to this branch.I've kicked off a few training runs on the OC20 S2EF-2M set with the above changes. Would be great to also establish parity on the smaller dataset.