Using decorated particles #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ConstLinearLayer.jl
This commit is a combination of two branches (using decorated particles and benchmark), based on which we can do a benchmark for state-related cases so that it could be used elsewhere. It also enables two types of input (state or just positions Vector{SVector{3}(...)}). By doing so, I believe both the `benchmark` and `temp_benchmark_and_state` branches can be removed.
|
A quick note: we have done a merge of both the So I think this PR, or say branch, can now be used in e.g. the developing version of |
|
This also take care of #22 . |
|
This PR is enourmous. I have no chance to review it all. On a quick skim what I've seen looks ok. Are you happy for me to merge on that basis? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable us to use DecoratedParticles as the input of an equivariant chain.