Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DummyCube initialisation #122

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix DummyCube initialisation #122

merged 2 commits into from
Oct 3, 2024

Conversation

truth-quark
Copy link
Collaborator

@truth-quark truth-quark commented Oct 2, 2024 •
edited
Loading

Closes #120.

This micro PR fixes some minor problems:

  • Instantiate self.attributes properly if attributes=None
  • Update, don't overwrite self.attributes
  • Improve attribute order / readability
  • Improve comments

@truth-quark
Fix DummyCube init to preserve attributes.
0af607b 
Reorder slightly for readability.
@truth-quark truth-quark self-assigned this Oct 2, 2024
@aidanheerdegen aidanheerdegen self-requested a review October 2, 2024 07:05
blimlim
blimlim previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Just had a tiny question about one of the comments.

aidanheerdegen
aidanheerdegen previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a question.

test/test_um2netcdf.py Outdated Show resolved Hide resolved
test/test_um2netcdf.py Show resolved Hide resolved
@truth-quark
Copy link
Collaborator Author

@aidanheerdegen @blimlim this code-homunculus requires another approval...

blimlim
blimlim approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@truth-quark truth-quark merged commit 33d0dc5 into main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blimlim blimlim blimlim approved these changes

@aidanheerdegen aidanheerdegen aidanheerdegen left review comments

Assignees

@truth-quark truth-quark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring DummyCube
3 participants
@truth-quark @aidanheerdegen @blimlim