Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to include Updating Configurations #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update README to include Updating Configurations #5

wants to merge 3 commits into from

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Sep 6, 2024

In this PR:

  • README.md: Added subsection on Updating a Configurations Version in 'Reusable CI'

References #4

@CodeGat CodeGat added the enhancement New feature or request label Sep 6, 2024
@CodeGat CodeGat self-assigned this Sep 6, 2024
aidanheerdegen
aidanheerdegen requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions about updated instructions.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
aidanheerdegen
aidanheerdegen approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, but do we need to add some warning in the updating bit that only minor versions are guaranteed bit reproducible, and this is an important criteria to consider before upgrading to a different major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-basevi jo-basevi jo-basevi left review comments

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeGat @aidanheerdegen @jo-basevi