Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease: Unique Modulefiles #54

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Apr 19, 2024

An oversight exists where prereleased models would have the same modulefile name as the soon-to-be-released one. For example, access-om3/2024.02.1. This would not change between commits in the PR, which would mean a bunch of deployed prereleases would share the same module name above, with only the first being pointed to.

This PR adds a step into the deployment workflow in which we modify the version of the root SBD that the model is based on, giving it a unique <model>/pr<number>-<commit> style, similar to the spack env name. For example, access-om3/pr12-2.

We've had to propagate the root-sbd input from the ci step all the way through the deployment workflow, as the yq that overwrites the version may have a different name than the actual name of the model. For example, we used to have access-om3-virtual being the root SBD of the access-om3 model, before it was changed.

@aidanheerdegen
Copy link
Member

If we added the modules to a different module path (in pre-release) this wouldn't be necessary. Just sayin'

@CodeGat
Copy link
Contributor Author

CodeGat commented Apr 24, 2024

How so? What would that look like?
Would that solve the issue of deploying multiple spack.yamls with the same modulefile projections, like {name}/2024.03.0?

@aidanheerdegen
Copy link
Member

How so? What would that look like?

mkdir /g/data/vk83/prerelease/modules

I feel like this is all dancing around similar areas as #59

Pre-release currently uses spack, spack-config and spack-packages from the release directory. If there was an entire replicated directory structure under prerelease then there would be a modules directory and all associated config etc.

Would that solve the issue of deploying multiple spack.yamls with the same modulefile projections, like {name}/2024.03.0?

Uh, no it wouldn't. We could either have a modulefile projection that just points to the most recent prerelease, or we'd have to make these changes anyway. As we're moving to using module load version within payu as the preferred way of changing model versions it makes sense to have all pre-release deployments available as modules (see ACCESS-NRI/model-config-tests#10).

So (kinda) ignore my comment above.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 2b85f90 into main Apr 26, 2024
@CodeGat CodeGat deleted the prerelease-unique-modulefiles branch April 26, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants