Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spack-config into config/settings.json #128

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Sep 16, 2024

Background

We've decided that we don't want model developers to be able to tweak the spack-config setting in their model deployment repositories config/versions.json file.

Thus, in this PR, we move that functionality into our protected config/settings.json file, as well as removing any reading/modification of spack-config from the deploy-*.yml and undeploy-*.yml workflow, as it should all be done in settings-*.yml.

This also means that we need to update the schema for deployment repos config/versions.json file - see ACCESS-NRI/schema#36

Important Notes

NOTE: This willl require that all the config/version.jsons in all model deployment repos remove the spack-config section, and update the CONFIG_VERSIONS_SCHEMA_VERSION to 3-0-0.

NOTE: This PR will fail deployment settings validation because it it using the @main version of the action rather than the PR version of the action. Independent validation of the config/settings.json has taken place - see https://github.com/codegat-test-org/test/actions/runs/10917132371/job/30299846971

This PR

In this PR:

  • validate-repo-version: update README instructions. See f68b53d
  • Remove reading/modification of spack-config from [un]deploy-2-*.yml workflows. See 26d0044
  • Update config/settings.json and config/settings.schema.json to allow for spack-config. See 24e1cfc
    • Update spack checks in validate-deployment-settings action since config/settings.schema.json was updated. See 6b429c4
    • Add new spack-config checks in `validate-deployment-settings. See ab5d062
  • settings-*.yml workflow now deploys changes to spack-config. See f5d3417

Closes #123

@CodeGat CodeGat force-pushed the 123-spack-config-in-settings-file branch from fd278a6 to f5d3417 Compare September 20, 2024 00:00
@CodeGat CodeGat marked this pull request as ready for review September 20, 2024 00:01
@CodeGat
Copy link
Contributor Author

CodeGat commented Sep 20, 2024

^ Sorry, you two are automatically listed as reviewers because I modified the config/settings.json file, which you are CODEOWNERS.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 0c65447 into main Sep 23, 2024
4 of 5 checks passed
@CodeGat CodeGat deleted the 123-spack-config-in-settings-file branch September 23, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move spack-config operations into config/settings.json
2 participants