Move spack-config
into config/settings.json
#128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We've decided that we don't want model developers to be able to tweak the
spack-config
setting in their model deployment repositoriesconfig/versions.json
file.Thus, in this PR, we move that functionality into our protected
config/settings.json
file, as well as removing any reading/modification ofspack-config
from thedeploy-*.yml
andundeploy-*.yml
workflow, as it should all be done insettings-*.yml
.This also means that we need to update the schema for deployment repos
config/versions.json
file - see ACCESS-NRI/schema#36Important Notes
NOTE: This willl require that all the
config/version.json
s in all model deployment repos remove thespack-config
section, and update theCONFIG_VERSIONS_SCHEMA_VERSION
to3-0-0
.NOTE: This PR will fail deployment settings validation because it it using the
@main
version of the action rather than the PR version of the action. Independent validation of theconfig/settings.json
has taken place - see https://github.com/codegat-test-org/test/actions/runs/10917132371/job/30299846971This PR
In this PR:
spack-config
from[un]deploy-2-*.yml
workflows. See 26d0044config/settings.json
andconfig/settings.schema.json
to allow forspack-config
. See 24e1cfcvalidate-deployment-settings
action sinceconfig/settings.schema.json
was updated. See 6b429c4settings-*.yml
workflow now deploys changes tospack-config
. See f5d3417Closes #123