-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin intake=0.7.0 #154
Pin intake=0.7.0 #154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 9 9
Lines 573 573
=======================================
Hits 557 557
Misses 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automated tests are passing and creating catalogs. There are some warnings but it looks like they existed before this change:
tests/test_manager.py::test_CatalogManager_build_esm[AccessCm2Builder-access-cm2/by578-kwargs1]
/home/runner/work/access-nri-intake-catalog/access-nri-intake-catalog/src/access_nri_intake/source/builders.py:152: UserWarning: Unable to parse 2 assets. A list of these assets can be found in `.invalid_assets` attribute.
self.get_assets().validate_parser().parse().clean_dataframe()
tests/test_manager.py::test_CatalogManager_build_esm[AccessCm2Builder-access-cm2/by578-kwargs1]
tests/test_manager.py::test_CatalogManager_build_esm[AccessCm2Builder-access-cm2/by578-kwargs1]
/home/runner/miniconda3/envs/access-nri-intake-test/lib/python3.11/site-packages/pydantic/deprecated/decorator.py:222: UserWarning: Unable to parse 2 assets/files. A list of these assets can be found in /tmp/test_invalid_assets.csv.
return self.raw_function(**d, **var_kwargs)
(also in https://github.com/ACCESS-NRI/access-nri-intake-catalog/actions/runs/7869512476/job/21468769290 which is before this change)
hh5 + conda/analysis and conda/analysis-unstable are both currently using intake=0.70
, so this change wouldn't have any impact.
I looked in vk83 + conda/access-med-0.6 and conda/access-med-0.7 and they are using intake 2.0.3, so these environments presumably don't work?
Thanks @anton-seaice - yup those warnings are expected.
Good point - we'll need to pin intake there too. I'll do that now |
Doesn't it just need rebuilding? It should pick up the dependency from this change ... |
Sorry, my comment is very unclear - I meant pin the version of access-nri-intake to at least the upcoming version |
This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there: |
Pin intake at 0.7.0 to avoid alpha intake v2. See #153 for context.