-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostic presets to pre-industrial+concentrations configuration #54
Add diagnostic presets to pre-industrial+concentrations configuration #54
Conversation
One thing to note: The addition of the separate I don't think these changes have made their way into the dev version of payu yet, and so the configuration might not work currently if you try to run with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cice stuff looks good. is diagnostics_requests
the best name for it ? I think diagnostics_profiles
or history_profiles
is better?
For the ocean |
That's a good point, and not something I have a great reason for. When setting up the For the diag_table_detailed where all 3D variables are saved at monthly frequency, I agree it's probably not useful to keep the yearly 3D variables at all. @minghangli-uni do you think the following would make more sense: diag_table_detailed:
diag_table_standard:
Let me know if this would sound a bit better, or any other ideas/suggestions would be great too! |
Sounds good to me! Thanks @blimlim |
Yep I think those are easier to understand – I've renamed the directories to |
@minghangli-uni, I've made those changes for the yearly ocean data, let me know if it's looking ok. @anton-seaice, for some reason I don't understand, the |
The standard monthly means include We should save Apologies for missing this one before, but we don't need orography in either of the daily sets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ocean diagnostics look good to me. Thanks, @blimlim
Thanks! I've added in The detailed preset already had a copy of this variable, though on the domain
@MartinDix, is it important to keep both of these, or is one of the domain selections incorrect? |
Only the version on the rho levels gets through to the output file so you can remove the theta one. The model seems to just silently ignore the one with theta levels. I couldn't find any messages in the log file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for all the work and constructive input from others.
Great! Thanks everyone for your help! |
This pull request adds Standard and Detailed diagnostic request presets for each submodel to the pre-industrial+concentrations configurations. Switching between the presets can be controlled by changing the relevant symlink in each submodel's control directory.
The changes to these presets compared to the previous default diagnostic requests are:
Atmosphere
Detailed: same as previous requests, though bugged wetland fraction field fld_s08i248, CO2 flux variables fld_s03i326 and fld_s03i327 which don't work in concentration mode, and fld_s03i173 which is named incorrectly are removed. Soil temp averaged over tiles added in.
Standard: Same as Detailed with most variables on model theta levels removed and most daily tiled data removed.
Ocean
Detailed: Same as previous requests, with all 3D monthly variables duplicated to yearly output. Variable renaming is removed, so that vanilla names are used. Variables that were requested previously requested but were not output by the model are not included.
Standard: Same as detailed but with several 3D monthly fields removed (kept at yearly frequency), as described here.
Both ocean diag_tables are generated via the
make_diag_table
script, and hence produce output with one variable per file.Ice
Detailed: Same as existing historical configuration (which included daily output for several fields), though with the bugged fields identified here removed.
Standard: Same as Detailed, with daily output removed.
Ice history namelist settings have been moved from the
cice_in.nml
to the separateice_history.nml
to enable swapping via symlinks.