Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33-b update cice diagnostics for pre-industrial configuration #36

Closed

Conversation

blimlim
Copy link

@blimlim blimlim commented Jul 31, 2024

This pull request completes the portion of #33 for the pre-industrial configuration. It:

  • Removes diagnostics impacted by the ESM1.5 coupling bug, and adds a comment with brief explanation.

@anton-seaice
Copy link

Apologies - i didnt realise this was different to the review on the historical branch .

I checked this out and did payu run (I tried payu-dev and payu-release) and got this error:

Traceback (most recent call last):
  File "/g/data/vk83/prerelease/apps/payu/dev/bin/payu", line 8, in <module>
    sys.exit(parse())
  File "/g/data/vk83/prerelease/apps/payu/dev/lib/python3.10/site-packages/payu/cli.py", line 41, in parse
    run_cmd(**args)
  File "/g/data/vk83/prerelease/apps/payu/dev/lib/python3.10/site-packages/payu/subcommands/sweep_cmd.py", line 16, in runcmd
    expt = Experiment(lab)
  File "/g/data/vk83/prerelease/apps/payu/dev/lib/python3.10/site-packages/payu/experiment.py", line 102, in __init__
    self.set_output_paths()
  File "/g/data/vk83/prerelease/apps/payu/dev/lib/python3.10/site-packages/payu/experiment.py", line 362, in set_output_paths
    assert (os.path.isdir(user_restart_dir))
AssertionError

I added added "modern" to the restart path, and then I got (on payu/1.1.3) :

FileNotFoundError: Executable for atmosphere model not found on path: /scratch/tm70/as2285/access-esm/bin/um_hg3.exe
Switched to payu/dev and it started. Ill update tomorrow. I guess we need to add somewhere (the readme?) it needs payu version >1.1.3. And the input paths need updating before we can make this change.

@blimlim
Copy link
Author

blimlim commented Aug 8, 2024

Ah sorry about this! There's a few changes happening to the configs/filepaths in different places and so this one's not working at the moment. Once the others are merged in I'll bring this one up to date so that it can run, and then will ping you when it's ready!

@anton-seaice
Copy link

I sanity checked a couple of the output fields (congel, frazil) and they don't exist (as expected)

Copy link

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are to update the input file paths in a different PR and then update this per comments :)

@blimlim
Copy link
Author

blimlim commented Aug 14, 2024

Closing this PR as selecting CICE diagnostics will be part of setting up the output presets.

@blimlim blimlim closed this Aug 14, 2024
@blimlim blimlim deleted the 33-pre-industrial-update-cice-diagnostics branch August 23, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants