Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spack.yaml Environment Configuration #5

Merged
merged 30 commits into from
Sep 23, 2024
Merged

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Apr 12, 2024

Initial changes to the spack.yaml to support the access-om3 SBD.

Closes #3

@CodeGat
Copy link
Contributor Author

CodeGat commented Apr 15, 2024

@harshula Would we be using a similar spack.modules section (here in the PR: https://github.com/ACCESS-NRI/ACCESS-OM3/pull/5/files#diff-e8582e74fa156f4e5729a850e52b24f2fde2d815c2c9c360f88c4cf90db851abR73-R78) to the ACCESS-NRI/ACCESS-OM2 one (here in the repo: https://github.com/ACCESS-NRI/ACCESS-OM2/blob/main/spack.yaml#L31-L60)

@harshula
Copy link
Collaborator

Hi @CodeGat , I think we will need to do the same for access-om3.

Copy link

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

1 similar comment
Copy link

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

Copy link

This ACCESS-NRI/ACCESS-OM3 model will be deployed with the following versions:

  • 2024.04.0 as a Release (when merged).
  • pr5-9 as a Prerelease (during this PR). This can be accessed on Gadi via spack at /g/data/vk83/prerelease/apps/spack/0.20/spack once deployed.

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

Copy link

This ACCESS-NRI/ACCESS-OM3 model will be deployed with the following versions:

  • 2024.04.0 as a Release (when merged).
  • pr5-10 as a Prerelease (during this PR). This can be accessed on Gadi via spack at /g/data/vk83/prerelease/apps/spack/0.20/spack once deployed.

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@CodeGat
Copy link
Contributor Author

CodeGat commented Apr 18, 2024

Note for tomorrow: it is deploying to 0.20 prerelease - we want to deploy to our prerelease fork. We might want to have that be a switch. See ACCESS-NRI/build-cd#21 - it's time has finally come!

@CodeGat CodeGat mentioned this pull request Apr 19, 2024
Copy link

This access-om3 model will be deployed with the following versions:

  • 2024.04.0 as a Release (when merged).
  • pr5-11 as a Prerelease (during this PR). This can be accessed on Gadi via spack at /g/data/vk83/prerelease/apps/spack/0.20/spack once deployed.

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@anton-seaice
Copy link
Contributor

I added this

tcl:
        hash_length: 0
        include:
          - access-om3
          - access-om3-nuopc
          - netcdf-c
          - netcdf-fortran
          - parallelio
          - esmf
          - fms
          - fortranxml

I did a spack concretise --fresh and spack install and the new install allowed a

module load access-om3-nuopc/git...

i.e. it works now

So I think this change needs to be made. Can I push it? How do you want to name the versions of these modules ?

Most of the default names seem ok?

----------------------------------------- /g/data/tm70/as2285/spack0.22_sep/release/modules/linux-rocky8-x86_64 -----------------------------------------
access-om3-nuopc/git.0.3.0_0.3.0                                            esmf/8.5.0        netcdf-c/4.9.2        
access-om3-nuopc/git.96f91599f746b4866bbd3f05ee6eb192ba70d391_0.3.0-git.15  fms/2023.02       netcdf-fortran/4.6.1  
access-om3/2024.04.0                                                        fortranxml/4.1.2  parallelio/2.6.2 

@CodeGat
Copy link
Contributor Author

CodeGat commented Sep 20, 2024

Hey @anton-seaice I've seen the above checks fail.
For Check spack.yaml (https://github.com/ACCESS-NRI/ACCESS-OM3/actions/runs/10953784507/job/30414616058?pr=5) we require an entry of access-om3-nuopc: '0.3.0' in the projections section, near the access-om3 one.
As for the other one CI / CI / Check Config Fields - that's a infrastructure bug and I'll get onto it now.

Copy link

github-actions bot commented Sep 20, 2024

🚀 Deploying access-om3 2024.04.0 as prerelease pr5-27

Details and usage instructions

This access-om3 model will be deployed as:

  • 2024.04.0 as a Release (when merged).
  • pr5-27 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr5-27

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr5-27 environment.

🛠️ Using: spack-packages 2024.07.08, spack-config 2024.07.05

Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

Copy link

🚀 Deploying access-om3 2024.04.0 as prerelease pr5-28

Details and usage instructions

This access-om3 model will be deployed as:

  • 2024.04.0 as a Release (when merged).
  • pr5-28 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr5-28

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr5-28 environment.

🛠️ Using: spack-packages `2024.07.08`, spack-config `2024.07.05`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

Copy link

🚀 Deploying access-om3 2024.09.0 as prerelease pr5-29

Details and usage instructions

This access-om3 model will be deployed as:

  • 2024.09.0 as a Release (when merged).
  • pr5-29 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr5-29

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr5-29 environment.

🛠️ Using: spack-packages `2024.07.08`, spack-config `2024.07.05`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@anton-seaice anton-seaice marked this pull request as ready for review September 23, 2024 01:59
anton-seaice
anton-seaice previously approved these changes Sep 23, 2024
Copy link
Contributor

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I have tested the pr5-29 build using ACCESS-NRI/access-om3-configs@a5fd61b and it starts and runs. This build points to the latest commit in COSIMA/access-om3@96f9159 and will work with the head of the current configurations under test.

We can continue to refine and improve this, but this gives us a starting point for using for Repro-CI testing

spack.yaml Outdated Show resolved Hide resolved
Copy link

🚀 Deploying access-om3 2024.09.0 as prerelease pr5-30

Details and usage instructions

This access-om3 model will be deployed as:

  • 2024.09.0 as a Release (when merged).
  • pr5-30 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr5-30

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr5-30 environment.

🛠️ Using: spack-packages `2024.07.08`, spack-config `2024.07.05`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@CodeGat CodeGat merged commit 961b0a0 into main Sep 23, 2024
11 checks passed
@CodeGat CodeGat deleted the 3-spack-yaml-versioning branch September 23, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some way to version this model from within the spack.yaml
6 participants