Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tutorial 2 #105

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

update tutorial 2 #105

wants to merge 19 commits into from

Conversation

JialiXu12
Copy link
Collaborator

Description:

Describe what changes you are adding

Related issue(s):

Mention related issues

Test Environment:

Specify the testing enviroment. e.g. OS, Python version

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PrasadBabarendaGamage
Copy link
Collaborator

Hi all, seems like there are some changes that need to be pulled in for tutorial 2? @JialiXu12 Just checking if this includes changes that were made during the workshop? I think I already committed most of these changes already - ie removing zip files etc and uploading the raw dataset. So think it’s only the changes that were made during the workshop that are missing. @LIN810116 I think you committed something too - are they the same changes here?

@chinchien-lin
Copy link
Contributor

Hi @JialiXu12 ,
I think some changes in this PR have been merged via other PRs. Some have been done by @PrasadBabarendaGamage 's commits. The latest Tutorial 2 has also been merged during the workshop by PR #106
@JialiXu12 Hoping you can check this again and make another PR for other changes that have not been merged.
You can do this by :

  • Pulling the latest version.
  • if there are any conflicts, please solve them locally
  • then submit a new PR

@PrasadBabarendaGamage
Copy link
Collaborator

Thanks all - one thing noticed was that there is some jupyter notebook cell output that is included in the commits. We just need to remember to clear all outputs before committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants