Update mod.py copy #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rules for accessing Discord channel is confusing and vague for the layman. I added more clarity.
kitlith
requested changes
Jul 13, 2018
| @@ -98,7 +98,7 @@ | |||
| """, | |||
| ) | |||
|
|
|||
| hidden_term_line = ' • When you have finished reading all of the rules, send a message in this channel that includes the sha1 of your discord `name#discriminator`, and we\'ll grant you access to the other channels. You can find your `name#discriminator` under the discord channel list.' | |||
There was a problem hiding this comment.
You shouldn't have removed the \, in this context it's an escape character that doesn't show up in the output but makes the ' after it be part of the text instead of ending the text.
|
I agree the message isn't ideal, but we're unfortunately limited in the message size. I like the wording, but we're going to have to further split the newcomer messages if we're going to use that, I think. |
|
Hmm actually it should be fine, we already have the logic to make the split dynamic. |
|
This can be closed, #29 contained a (vaguer on purpose) version of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule / instruction for accessing Discord channel (via discriminator to sha1 hash conversion) is confusing and vague for the layman. I added more clarity. This will ensure we aren't filtering out casual Discord users who may have something valuable to contribute.