Resolve linting issues

[neBM]

I've had a look at some ideas for solving the detekt issues and I believe we can abstract out a large proportion of the params from the JellyfinMediaSource.

For convenience, I've broken the PR into two commits:

• One commit resolves the trivial quick fixes
• Another solves LongParameterList error

Please feel free to merge if you like what you see. 😄

This is in relation to jellyfin#1404.

[neBM]

I haven't been able to test this as I'm having issues spawning an emulator so I've marked this as draft, but I'm hoping it's a good start to a solution.

[7ritn]

I really like this idea of splitting between a local and a remote jellyfin data source. However, I wonder if it could be confusing, since the RemoteJellyfinMediaSource could also potentially use a cached download if available.

I will look into your changes and test them out. Thanks so much!

[7ritn]

I think it is a really good idea, however oftentimes I think a JellyfinMediaSource would be more approriate compare to the specific RemoteJellyfinMediaSource. What do you think? Furthermore moving the additional downloads specs into the LocalJellyfinMediaSource structure could be really beneficial

[neBM]

I think it is a really good idea, however oftentimes I think a JellyfinMediaSource would be more approriate compare to the specific RemoteJellyfinMediaSource. What do you think? Furthermore moving the additional downloads specs into the LocalJellyfinMediaSource structure could be really beneficial

Ah! I hadn't considered caching... good thinking — I agree. Do you have any preference over what we could call the POJO?

Ooo yes, I'll have a look into migrating the additional downloads specs adapter too 😋

[neBM]

Marking this as ready as I've done quick testing locally and current functionality appears to be working. I'll continue with the suggested changes.

[7ritn]

Looks really good, it is basically ready to merge, just wondering regarding the enforcement of RemoteJellyfinMediaSource when switching Audio or Subtitle Track?

[7ritn]

So you want to work on moving the downloads specs from the database to the LocalJellyfinMediaSource structure?

[neBM]

So you want to work on moving the downloads specs from the database to the LocalJellyfinMediaSource structure?

Hi! Yep, all done! Please have a look over the additions for me and let me know what you think.

It might be worth double checking switching with encoded subtitles as I don't have media to test this to hand.
This is in reference to:

jellyfin-android/app/src/main/java/org/jellyfin/mobile/player/TrackSelectionHelper.kt

Line 101 in d3b7ae5

return viewModel.queueManager.selectSubtitleStreamAndRestartPlayback(selectedMediaStream)

[7ritn]

Looks good works well with external subtitles on my phone :)

[7ritn]

Thanks for your work ^^

[neBM]

Thanks for your work ^^

And thank you for all your feedback :) That was good fun!