-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: integrate sbt-doctest #1260
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1260 +/- ##
===========================================
+ Coverage 53.92% 53.94% +0.01%
===========================================
Files 431 431
Lines 8070 8070
Branches 365 365
===========================================
+ Hits 4352 4353 +1
+ Misses 3718 3717 -1 |
b5b1b76
to
5cae759
Compare
|
Jeez, I'm so sorry, somehow, I've just missed a notification about this 🤦 . I didn't ignore this, just missed it out, sorry. |
@VladPodilnyk no worries! |
be4d382
to
6dda1f0
Compare
Current blocker:
sbt-doctest
generates test files inside the current artifact's test scope, but e.g. code examples indistage-core-api
forward-reference classes that are only available indistage-core
and onward — they cannot compile indistage-core-api / test
scope. Now, this parameter the directory to dump source files to is controlled by this line https://github.com/tkawachi/sbt-doctest/blob/master/src/main/scala/com/github/tkawachi/doctest/DoctestPlugin.scala#L103, if we provide an alternative definition fordoctestGenTests
that uses a different key instead ofmanagedSourceDirectories in Test
, we could override that key and dump the tests into a different directory (e.g.microsite
- where all the libraries are available at the same time)/cc @vpodlnk @VladPodilnyk - would you be interested in exploring this task?