Fix tab change & reload page issue #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DSC-1408] - Fix dropdown readonly field Approved-by: Andrea Barbasso
# Conflicts: # src/config/default-app-config.ts # src/environments/environment.test.ts
[DSC-1352] Move breadcrumb char limit property inside layout configuration properties Approved-by: Andrea Barbasso
DSC-1037 Approved-by: Giuseppe Digilio
[DSC-1430] Add missing labels
[DSC-1434] feature: update twitter to x button Approved-by: Davide Negretti
…on item-collection mapper
Release DSpace-CRIS 7 2023.02.01
# Conflicts: # package.json
Change section labels according to changes done in the submission form excel file
…-xls-metadata-export
Item mapper main DSC-1073 Approved-by: Stefano Maffei
[DSC-1066] search-filter query with [ ] Approved-by: Stefano Maffei
…1387-export-menu-in-person-entity-main-cris
DSpace#1315) DSC-1387 export menu in person entity main cris Approved-by: Davide Negretti
DSC-983 counters component main
Gdpr metrics DSC-1522 Approved-by: Andrea Barbasso Approved-by: Giuseppe Digilio
Authority source DSC-1498 Approved-by: Stefano Maffei
# Conflicts: # package.json
# Conflicts: # src/config/default-app-config.ts # src/environments/environment.test.ts
* dspace-cris-2023_02_x: (65 commits) [DSC-397] fix issue that lead to failing e2e [DSC-1653] removed comments [DSC-1653] Defined a mixin for vertical ellipsis [DSC-1637] resolve conflicts [DSC-1601] - Added test case [DSC-1601] - Adjusted code for fixing requested [DSC-1601] - Added new implementation when bitstream is restricted [DSC-1601] - Removed old implementation [DSC-1575] Fixed labels name [CST-9683] Fix visualization order of the metrics boxes in the item page [DSC-1524] Use ngOnChanges to detect changes on input variable [DSC-1655] Configure person icon to be visible without authority [DSC-1628] change icon color in config [DSC-1524] Adjusted test for End User Agreement not shown [DSC-1524] Fixing End User Agreement not shown [DSC-1652] fix lint [DSC-1652] refactor translateService calls, change default values for timeouts [DSC-1575] Added labels required [DSC-1652] add warning and error messages to loader component [DSC-1601] Fixed issue with icon visibility in FileDownloadLinkComponent ... # Conflicts: # package.json # src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.scss # src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.ts
|
Hello @oye816 from which branch have you created your working branch related to this PR. |
|
Ok, I will create new PR from dspace-cris-2023_02_x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add references/links to any related issues or PRs. These may include:
Description
Fix tab change & reload page issue
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
yarn lintyarn check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.