Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds version information to CRIS item page #75

Open
wants to merge 1 commit into
base: main-cris
Choose a base branch
from

Conversation

olli-gold
Copy link

@olli-gold olli-gold commented Feb 26, 2024

References

Description

This PR adds the missing version information to the CRIS item page if applicable.

Effectively, it adds a notice about an existing newer version of the item on itempages for an old version and a version history information on any itempage handling a versioned item.

grafik
grafik

Instructions for Reviewers

This PR integrates the reference to a new version and the version history to CRIS item pages. To review, create a versioned item and view the item page. On the item page of the old version, there should be a reference to the new version. On any item page involved with the versioned item, the version history should be shown.

You can also find a live example on https://doi.org/10.15480/336.2396.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@z-stoynova
Copy link

I have tested this PR and I can confirm that the version table in all version Items and the link to the latest version in all previous item is added and shown:

image

image

image

The link to the latest version in the last screenshot is properly generated.

However we noticed that the links to the version Items in the version table (host-url/items/version/versionId) cannot be resolved by the backend and a 404 (Not Found) Error is returned.This is explicitely described in issue dspace-angular#67.

The suggested code in this PR does exactly what is described but the desribed version link problem shows that there is an underlying bug in the generation of item version links. This was tested with dspce-cris-2023.02.02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version information not visible on DSpace-CRIS itempages
2 participants