Merged in task/dspace-cris-2023_02_x/DSC-1920 (pull request DSpace#2706)

[DSC-1920] fix ads.id metadata mapping for ads Approved-by: Stefano Maffei
4Science · Sep 9, 2024 · 79e494b · 79e494b
2 parents 1a7844d + 0bdd543
commit 79e494b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dspace-server-webapp/src/test/java/org/dspace/app/rest/ADSImportMetadataSourceServiceIT.java b/dspace-server-webapp/src/test/java/org/dspace/app/rest/ADSImportMetadataSourceServiceIT.java
@@ -171,7 +171,7 @@ private ArrayList<ImportRecord> getRecords() {
         MetadatumDTO author4 = createMetadatumDTO("dc", "contributor", "author", "Virgo Collaboration");
         MetadatumDTO doi = createMetadatumDTO("dc", "identifier", "doi", "10.1103/PhysRevLett.116.061102");
         MetadatumDTO type = createMetadatumDTO("dc", "type", null, "article");
-        MetadatumDTO adsbibcode = createMetadatumDTO("dc", "identifier", "other", "2016PhRvL.116f1102A");
+        MetadatumDTO adsbibcode = createMetadatumDTO("dc", "identifier", "adsbibcode", "2016PhRvL.116f1102A");
         MetadatumDTO date = createMetadatumDTO("dc", "date", "issued", "2016");
         MetadatumDTO subject = createMetadatumDTO("dc", "subject", null, "General Relativity and Quantum Cosmology");
         MetadatumDTO subject2 = createMetadatumDTO("dc", "subject", null,
@@ -222,7 +222,7 @@ private ArrayList<ImportRecord> getRecords() {
         MetadatumDTO author8 = createMetadatumDTO("dc", "contributor", "author", "Wade, M.");
         MetadatumDTO doi2 = createMetadatumDTO("dc", "identifier", "doi", "10.1103/PhysRevLett.119.161101");
         MetadatumDTO type2 = createMetadatumDTO("dc", "type", null, "article");
-        MetadatumDTO adsbibcode2 = createMetadatumDTO("dc", "identifier", "other", "2017PhRvL.119p1101A");
+        MetadatumDTO adsbibcode2 = createMetadatumDTO("dc", "identifier", "adsbibcode", "2017PhRvL.119p1101A");
         MetadatumDTO date2 = createMetadatumDTO("dc", "date", "issued", "2017");
         MetadatumDTO subject3 = createMetadatumDTO("dc", "subject", null, "General Relativity and Quantum Cosmology");
         MetadatumDTO subject4 = createMetadatumDTO("dc", "subject", null,

diff --git a/dspace/config/spring/api/ads-integration.xml b/dspace/config/spring/api/ads-integration.xml
@@ -74,7 +74,7 @@
         <property name="query" value="/bibcode"/>
     </bean>
     <bean id="ads.id" class="org.dspace.importer.external.metadatamapping.MetadataFieldConfig">
-        <constructor-arg value="dc.identifier.other"/>
+        <constructor-arg value="dc.identifier.adsbibcode"/>
     </bean>
 
     <bean id="adsTypeContrib" class="org.dspace.importer.external.metadatamapping.contributor.SimpleJsonPathMetadataContributor">