style: Use useSyncExternalStore in the React adapter #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bartlangelaan is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks, wow this is so much cleaner! I had heard of useSyncExternalStore, but it didn't occur to me to use it here, it sounds like a perfect use-case. Great job! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
added
the
deploy:preview
|
I don't have time to test it today, so if you can't wait and want to test it, feel free! :-) |
|
Regarding the emitter, it's use is to make sure the |
franky47
added
deploy:preview
commit: |
bartlangelaan
force-pushed
the
use-sync-external-store-react-adapter
branch
from
7a5fcba
to
6b2e0a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes the
useSyncExternalStorehook in the React adapter, which automatically takes care of rehydration errors.I'm unsure if it still works correctly, because this version does not use the emitter value anymore. It just gets it from the location every time. I will test it before marking it as ready.