[WIP] Upgrade to CentOS stream9 #3866
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was caused by `draper` gem upgrade (which was a result of upgrading Ruby to v3). The issue was here: https://github.com/drapergem/draper/blob/v4.0.2/lib/draper/automatic_delegation.rb#L10-L26 In decorators we delegate all methods to the decorated object. But this version of the library only does that when there is no private method with the same name on the decorator. In this case, as `admin_user` was a private method on AccountDecorator, draper tried to call `admin_user `on superclass, but it was not there, so it was failing with: ``` ActionView::Template::Error (super: no superclass method `admin_user' for #<AccountDecorator:0x00007f8784266d18 @object=#<Account id: 11, org_name: "Testing" ...> Did you mean? admin_user_email): ``` Removing it from `private_methods` fixed the issue.
This test caused multiple tests fail with: ``` ThreadError: deadlock; lock already owned by another fiber belonging to the same thread ``` This is fixed in Rails 7.0.6 and higher: rails/rails#46553
```
DEPRECATION WARNING: Passing a path to `fixture_file_upload` relative to `fixture_path` is deprecated.
In Rails 7.0, the path needs to be relative to `file_fixture_path`.
Please modify the call from
`fixture_file_upload("wide.jpg")` to `fixture_file_upload("../../../test/fixtures/wide.jpg")`.
(called from block (4 levels) in <main> at /home/dmayorov/Projects/3scale/porta/spec/acceptance/api/cms_file_spec.rb:24)
```
jlledom
reviewed
Aug 21, 2024
| @@ -109,7 +107,7 @@ ENV THINKING_SPHINX_ADDRESS=0.0.0.0 \ | |||
| SECRET_KEY_BASE=dummy \ | |||
| DATABASE_URL='mysql2://root:@localhost/porta' | |||
| USER 0 | |||
| RUN dnf install -y mysql-server mysql-test \ | |||
| RUN dnf install --enablerepo=crb -y mysql-server mysql-test \ | |||
There was a problem hiding this comment.
mysql package is in this repo that is available but not enabled by default
mayorova
force-pushed
the
ruby-3.1
branch
4 times, most recently
from
52431d5
to
1de699d
Compare
|
This PR is stale because it has not received activity for more than 30 days. Remove stale label or comment or this will be closed in 15 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3847
The corresponding builder image is: 3scale/system-builder#41