feat: new ContempCache1.0 #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActivePeter
reviewed
Oct 31, 2024
| @@ -12,7 +12,7 @@ pub struct FifoCache<Payload: Eq + Hash + Clone + Debug> { | |||
| } | |||
|
|
|||
| impl<Payload: Eq + Hash + Clone + Debug> InstanceCachePolicy<Payload> for FifoCache<Payload> { | |||
| fn get(&mut self, key: Payload) -> Option<Payload> { | |||
| fn get(&mut self, key: Payload, last_mem_use: f32) -> Option<Payload> { | |||
There was a problem hiding this comment.
能不能直接传进来该缓存所在的节点对应的实例的状态，不然后续你扩展新的缓存可能要观测别的数据，又得传新的变量；随着策略增多改动会越来越麻烦
| @@ -13,7 +13,7 @@ pub struct LRUCache<Payload: Eq + Hash + Clone + Debug> { | |||
| } | |||
|
|
|||
| impl<Payload: Eq + Hash + Clone + Debug> InstanceCachePolicy<Payload> for LRUCache<Payload> { | |||
| fn get(&mut self, key: Payload) -> Option<Payload> { | |||
| fn get(&mut self, key: Payload, last_mem_use: f32) -> Option<Payload> { | |||
| }; | ||
| use std::{ collections::HashMap, fs::File }; | ||
| use std::{collections::HashMap, fs::File, ptr::NonNull}; |
There was a problem hiding this comment.
NonNull 没用去掉吧，可以跑一遍cargo fix
| @@ -209,7 +217,7 @@ impl Node { | |||
| // self.fn_containers.get(&fnid) | |||
| // } | |||
|
|
|||
There was a problem hiding this comment.
这里加上的注释解释下if down的作用吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.