perf: temp_scaler, bp_balance, load_least, #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure_scaler, ensure_scheduler, lass, pass, rotate. and Three types of load plots
ActivePeter
requested changes
Oct 31, 2024
There was a problem hiding this comment.
What is this feature? Can the script's purpose be included in its name? Please also attach the Feishu documentation.
| @@ -1,44 +1,93 @@ | |||
|
|
|||
| avg_cnt: 1 | |||
|
|
|||
| ## filter with fixed value | |||
There was a problem hiding this comment.
link the Introduction in feishu of this yaml
| @@ -0,0 +1,131 @@ | |||
| # 自动运行同路径下的run_different_req_freq.py | |||
| import os | |||
| CUR_FPATH = os.path.abspath(__file__) | |||
There was a problem hiding this comment.
为什么有一个单独的文件叫draw script，其他的脚本外面还有几个draw脚本，建议直接放到一个层级下
| let schedule_able_fns = schedule_helper::collect_task_to_sche( | ||
| req, | ||
| env, | ||
| schedule_helper::CollectTaskConfig::PreAllSched, |
There was a problem hiding this comment.
pre all sched是 pos的核心逻辑，为什么ensure也用的这个
| } | ||
| else { | ||
| cur_container_cnt + sqrt_container_cnt | ||
| if need_to_schedule || cur_container_cnt == 0 { |
There was a problem hiding this comment.
当前容器数为0，不需要调度的情况，为什么要走这个逻辑，走了这个逻辑就到==0的case，返回1了
|
|
||
| log::info!("fnid:{}, frame:{}, recent_speed:{}", fnid, env.core().current_frame(), recent_speed); | ||
|
|
||
| if recent_speed < 0.00001 && need_to_schedule{ |
There was a problem hiding this comment.
这个是自己论文的话建议飞书里建个文档仔细的介绍下，连接到主页
| @@ -88,7 +83,7 @@ impl Scheduler for EnsureScheduler { | |||
| let schedule_able_fns = schedule_helper::collect_task_to_sche( | |||
| req, | |||
| env, | |||
| schedule_helper::CollectTaskConfig::PreAllSched, | |||
| schedule_helper::CollectTaskConfig::All, | |||
There was a problem hiding this comment.
这一块确认清楚，尤其是scaler那里和这并不一样，最好引用一下文档，在文档里解释下原文实现和这个的映射
There was a problem hiding this comment.
pass的实现怎么是随机，我记得不是静态贪婪嘛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure_scaler, ensure_scheduler, lass, pass,
rotate.
and Three types of load plots