Skip to content

Commit

Permalink
Windows app: switch over to 64bit for good
Browse files Browse the repository at this point in the history
  • Loading branch information
NathanDunfield committed Sep 8, 2023
1 parent 6c20e8d commit fa45532
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
1 change: 1 addition & 0 deletions windows_exe/InnoSnapPy_dbg.iss
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ OutputDir=.
OutputBaseFilename=InstallSnapPy-Dbg
Compression=lzma
SolidCompression=yes
ArchitecturesInstallIn64BitMode=x64

[Languages]
Name: "english"; MessagesFile: "compiler:Default.isl"
Expand Down
1 change: 1 addition & 0 deletions windows_exe/InnoSnapPy_py3.iss
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ OutputDir=.
OutputBaseFilename=InstallSnapPy-Python3
Compression=lzma
SolidCompression=yes
ArchitecturesInstallIn64BitMode=x64

[Languages]
Name: "english"; MessagesFile: "compiler:Default.isl"
Expand Down
12 changes: 4 additions & 8 deletions windows_exe/make.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@
this_pyinstaller = os.path.abspath(
os.path.join(this_python, '..', 'Scripts', 'pyinstaller'))

# We currently build the Windows apps as 32 bit apps only. The reason for
# this is a mysterious unresolved issue with the 64 bit app, namely
# that when installed in C:\Program Files it takes close to one minute
# to start up. While it does start up normally if installed elsewhere,
# we want to resolve this issue before releasing a 64 bit app.

if platform.architecture()[0] != '32bit' and '--64-bit' not in sys.argv:
print("ERROR: Need to use a 32bit Python to build the apps")
# The Inno Installer config file (*.iss) assumes a 64 bit binary.

if platform.architecture()[0] != '64bit' and '--32-bit' not in sys.argv:
print("ERROR: Need to use a 64bit Python to build the apps")
sys.exit(1)

try:
Expand Down

0 comments on commit fa45532

Please sign in to comment.