Skip to content

Commit

Permalink
Fix to Triangulation -> Link -> Triangulation reversing orientation
Browse files Browse the repository at this point in the history
If a Triangulation is specified by a DT code *with flips*, then one
could *sometimes* change the orientation of the exterior by what should
have been a no-op::

   >>> E0 = snappy.Manifold('DT[eaebdeac.11100]')
   >>> E0.chern_simons()
   0.153204133297152
   >>> E0.link().exterior().chern_simons()
   -0.153204133297152

This only happened in certain circumstances, and the DT codes in
HTLinkExteriors were seemingly immune.

This bug had the same root cause as dd9a2e7.
  • Loading branch information
NathanDunfield committed Aug 14, 2023
1 parent 223badf commit 308d7f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cython/core/triangulation.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ cdef class Triangulation():
if self._PDcode is not None:
return spherogram.Link(self._PDcode)
elif self.DT_code() is not None:
return spherogram.DTcodec(self.DT_code()).link()
return spherogram.DTcodec(*self.DT_code(flips=True)).link()
else:
raise ValueError('No associated link known.')

Expand Down

0 comments on commit 308d7f7

Please sign in to comment.