Improve readability of Nima-Unity-Testing as an example repository #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using directives to improve hack-ability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used Nima for a Unity project and it took some hacking and reading source code to be able to get anything running. It seems like there are some files missing from Nima-Unity-Testing, so this PR seeks to add those in, along with updating the repo for 2020.
There is now an ArcherSampleScene that has a working version of the Archer added to the scene. ArcherController.cs was also copied into Nima-Unity-Testing and modified to look more like a typical game script. I felt it was weird to have an example script that was included and namespaced within the library. Expect a pull request removing this from Nima-Unity as well.
Happy to field any questions or feedback. I believe this PR will make it significantly easier for new users to take advantage of Nima's Unity integration.
P.S. It would be nice if the Archer asset were forkable in Rive, it's currently not allowed: https://rive.app/a/castor/files/nima/archer/preview