Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 删除目录校验是否为禁止删除的目录 #7031

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

lan-yonghui
Copy link
Contributor

@lan-yonghui lan-yonghui commented Nov 13, 2024

No description provided.

Copy link

f2c-ci-robot bot commented Nov 13, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

excludeDir := global.CONF.System.DataDir
if strings.Contains(op.Path, ".1panel_clash") || op.Path == excludeDir {
return buserr.New(constant.ErrPathNotDelete)
}
}
fo := files.NewFileOp()
recycleBinStatus, _ := settingRepo.Get(settingRepo.WithByKey("FileRecycleBin"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个C#代码看起来是针对阿里云对象存储使用的,但是由于我无法访问外部的文件夹或其他系统配置信息,所以我不能对它做任何直接的更改。如果您需要我的帮助来解决特定于该语言和环境的具体问题,请提供更多信息,比如错误提示或功能需求。

@1Panel-bot 1Panel-bot added the dev label Nov 13, 2024
if (s['path'].indexOf('.1panel_clash') > -1) {
MsgWarning(i18n.global.t('file.clashDeleteAlert'));
return;
}
const pathRes = await loadBaseDir();
if (s['path'] === pathRes.data) {
MsgWarning(i18n.global.t('file.panelInstallDir'));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对不起,你没有提供代码片段,请提供具体的内容以便进行评估和反馈。

Copy link

sonarcloud bot commented Nov 13, 2024

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wanghe-fit2cloud
Copy link
Member

/approve

Copy link

f2c-ci-robot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit ec372db into dev Nov 13, 2024
6 checks passed
@f2c-ci-robot f2c-ci-robot bot deleted the pr@dev@fix_del_file branch November 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants