Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added switch between usd/eth on main page #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juliangnr90
Copy link

Hi, this is my first Pull Request, this issue came to me from Harthor (He talk to me about 1Hive). Basically what I do is to create a function that convert every USD price into ETH, first I try to get ethereum value from state. Then I use that value on every rendering of usd price.
Of course the props that I pass on components always check that exists to prevent side effect on other parts of the project.
Hope you like what I did and I'm open to any recommendation to improve the code

@vercel
Copy link

vercel bot commented Sep 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/1hive/honeyswap-analytics/8h83mLBnSD7GjdXjX1G66SygD2DT
✅ Preview: Failed

Copy link
Member

@Harthor Harthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works properly, it could be added also for Tokens, Pairs and Accounts tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants