Fix deprecation warning for htmlspecialchars (#670)

Co-authored-by: Nícholas André <[email protected]>
10up · Jan 19, 2024 · f18be49 · f18be49 · vercel · Jan 19, 2024
1 parent 297cc47
commit f18be49
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/cyan-badgers-smile.md b/.changeset/cyan-badgers-smile.md
@@ -0,0 +1,5 @@
+---
+"@headstartwp/headstartwp": patch
+---
+
+Ensure htmlspecialchars receives an empty string instead of null to fix deprecation warnings.
diff --git a/wp/headless-wp/includes/classes/API.php b/wp/headless-wp/includes/classes/API.php
@@ -98,7 +98,7 @@ public function modify_rest_params( $args, $request ) {
 			return $args;
 		}
 
-		$author = htmlspecialchars( filter_input( INPUT_GET, 'author' ) );
+		$author = htmlspecialchars( filter_input( INPUT_GET, 'author' ) ?? '' );
 
 		if ( ! empty( $author ) && ! is_numeric( $author ) ) {
 			unset( $args['author__in'] );
@@ -108,10 +108,10 @@ public function modify_rest_params( $args, $request ) {
 		$taxonomies = wp_list_filter( get_object_taxonomies( $args['post_type'], 'objects' ), [ 'show_in_rest' => true ] );
 
 		foreach ( $taxonomies as $taxonomy ) {
-			$term = htmlspecialchars( filter_input( INPUT_GET, $taxonomy->name ) );
+			$term = htmlspecialchars( filter_input( INPUT_GET, $taxonomy->name ) ?? '' );
 
 			if ( ! $term ) {
-				$term = htmlspecialchars( filter_input( INPUT_GET, $taxonomy->rest_base ) );
+				$term = htmlspecialchars( filter_input( INPUT_GET, $taxonomy->rest_base ) ?? '' );
 			}
 
 			if ( ! empty( $term ) && ! is_numeric( $term ) ) {