fix: images without width/height (#589)

10up · Aug 29, 2023 · de501ff · de501ff · vercel · Aug 29, 2023
1 parent e2f8f4b
commit de501ff
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/lucky-bears-think.md b/.changeset/lucky-bears-think.md
@@ -0,0 +1,6 @@
+---
+"@headstartwp/core": patch
+"@headstartwp/next": patch
+---
+
+Fix an issue for images without width or height
diff --git a/packages/core/src/react/blocks/ImageBlock.tsx b/packages/core/src/react/blocks/ImageBlock.tsx
@@ -41,6 +41,8 @@ export function ImageBlock({
 	}
 
 	const { src, alt, width: imgNodeWidth, height: imgNodeHeight } = imgNode.attribs;
+	const imageWidth = width ?? imgNodeWidth;
+	const imageHeight = height ?? imgNodeHeight;
 
 	return (
 		<Component
@@ -50,8 +52,8 @@ export function ImageBlock({
 			src={src}
 			alt={alt}
 			attributes={blockAttributes}
-			width={width || Number(imgNodeWidth)}
-			height={height || Number(imgNodeHeight)}
+			width={imageWidth ? Number(imageWidth) : undefined}
+			height={imageHeight ? Number(imageHeight) : undefined}
 			style={style}
 		>
 			{children}

diff --git a/packages/next/src/components/ImageComponent.tsx b/packages/next/src/components/ImageComponent.tsx
@@ -102,7 +102,7 @@ export function ImageComponent({ src, alt, width, height, children, style, loade
 	}
 
 	if (!width || !height) {
-		<Image src={src} alt={alt || ''} fill style={style} loader={loader} />;
+		return <Image src={src} alt={alt || ''} fill style={style} loader={loader} />;
 	}
 
 	return (