fix: issue where canonical was missing trailing slash (#567)

Co-authored-by: Nícholas Oliveira <[email protected]>

.changeset/curly-apricots-stare.md

@@ -0,0 +1,5 @@
+---
+"@headstartwp/next": patch
+---
+
+Fix: only convertUrls if url starts with sourceUrl

packages/next/src/components/Yoast.tsx

@@ -12,8 +12,15 @@ import {
 import { useSettings } from '@headstartwp/core/react';
 import Head from 'next/head';
 
-function convertUrl(url: string, hostUrl: string, sourceUrl: string) {
-	return `${hostUrl}${removeSourceUrl({ link: url, backendUrl: sourceUrl })}`;
+export function convertUrl(url: string, hostUrl: string, sourceUrl: string) {
+	if (!url.startsWith(sourceUrl)) {
+		return url;
+	}
+
+	return `${hostUrl}${removeSourceUrl({
+		link: url.replace(/\/?$/, '/'),
+		backendUrl: sourceUrl,
+	})}`;
 }
 
 type Props = {

packages/next/src/components/__tests__/Yoast.tsx

@@ -0,0 +1,25 @@
+import { convertUrl } from '../Yoast';
+
+describe('convertUrl', () => {
+	it('root works without trailing slash', () => {
+		expect(
+			convertUrl('https://test.com/test', 'https://test.test.com', 'https://test.com/test'),
+		).toBe('https://test.test.com/');
+	});
+
+	it('root works with trailing slash', () => {
+		expect(
+			convertUrl('https://test.com/test/', 'https://test.test.com', 'https://test.com/test'),
+		).toBe('https://test.test.com/');
+	});
+
+	it('external url returns external url', () => {
+		expect(
+			convertUrl(
+				'https://external.com/test',
+				'https://test.test.com',
+				'https://test.com/test',
+			),
+		).toBe('https://external.com/test');
+	});
+});