Check return value of get_post_meta

[dhanendran]

Description of the Change

Validate the return value of get_post_meta and make sure it is array.

Closes #1107

How to test the Change

1. Enable debug logging in wp-config

define( 'WP_DEBUG', true );
define( 'WP_DEBUG_LOG', true );
define( 'WP_DEBUG_DISPLAY', false );

2. Run wp shell and call the function with an invalid post ID: \Distributor\Utils\prepare_meta('bug');
3. Open the debug.log file in your wp-content directory and observe the no warning is thrown: PHP Warning: Invalid argument supplied for foreach() in .../includes/utils.php on line 427

Changelog Entry

Fixed - PHP warning about invalid argument supplied for foreach in \Distributor\Utils\prepare_meta()

Credits

Props @dhanendran

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[faisal-alvi]

@dhanendran Thanks for the PR. As the return value of get_post_meta() is mixed, it may return false and we will end up overwriting it with an array() which may throw the PHP warning in v8+.

[faisal-alvi]

@kirtangajjar thanks for the fix. A couple of minor PHPCS issues are noted below.

An early return would work but will never reach the dt_prepared_meta filter. We can consider it as an exception though (i.e. empty meta would not reach the filter).

[kirtangajjar]

@faisal-alvi Made the requested changes. LMk if there are any more

[faisal-alvi]

Ignoring E2E failures as they are being addressed in #1242