Added ability to view all post types when Pulling from an External Connection

[mehul0810]

Description of the Change

Add the ability to view all post types when pulling content from external connections.

Closes #861

How to test the Change

• Go to Distributor > Pull Content (Make sure you have added an internal as well as external connection)
• Check and confirm that "View All" filter is available for both internal and external connection
• Check and confirm that filtering with "View All", displays posts from all the post types for both internal and external connection

Changelog Entry

Added - Introduce "View all" post type view when pulling content from external connections.

Credits

Props @mehul0810, @ravinderk, @cadic, @peterwilsoncc, @ankitrox, @Sidsector9, @jeffpaul.

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[cadic]

Thanks for the PR @mehul0810

I've left couple non-blocking questions and a suggestion for the $args in get_pull_content()

[peterwilsoncc]

In #1017 (awaiting merge) I've made a bunch of modifications to the rest api endpoint that should make this more achievable. It will probably cause a lot of conflicts to this PR though.

You'll be able to use post_type => any once that PR is merged as the custom endpoint will modify the value to only include post types the user can read, either because they have permission or the post type is publicly viewable.

[github-actions]

@mehul0810 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

[peterwilsoncc]

I've left on question/comment inline.

I was getting a bunch of array to string notices so I pushed 7cdc43b to resolve that. WP_Query accepts all to query all of the post types so that can be used for the option.

The custom endpoint also accepts All as a shorthand.

[peterwilsoncc]

The default is set to post in get_pull_content_list_args() so it's unlikely this will ever be set to [post, page].

I included it back when I was rewriting this as a safety check just in case someone messes with the URL.

Was the intent with this change to default to the View All view? For internal connections Distributor offers a View All view but defaults to posts only, so I think it's best to match that for the time being.

[mehul0810]

@peterwilsoncc Replaced it to show only the post by default.

The intent with this change was to get the list of post type that needs to be listed or else default to post. But, we are not defaulting the post type filter to View All. It is still Post

[Sidsector9]

I am seeing some unusual behaviour with the "View All" selection. Watch the video below:

Screen-2024-07-10-60918.PM.mp4

Additionally, only posts are being pulled.

[kirtangajjar]

I can confirm that I can see something strange as well. It looks like when we select "view all" only posts by "admin" users are shown. That's what it looks on the surface(which may not be the case as well), needs more investigation.

Screen.Recording.2024-07-13.at.10.30.18.AM.1.mp4

[kirtangajjar]

I think what I and sid observed was perhaps a security fix, so it's all good? #1003 (review)

[jeffpaul]

@peterwilsoncc if this looks good to you, please merge, thanks!

[peterwilsoncc]

I think what I and sid observed was perhaps a security fix, so it's all good? #1003 (review)

It looks like it's a bug in WP_Query when querying multiple post types using the perm argument added as part of the security fix.

distributor/includes/rest-api.php

Line 693 in 253cf82

$args['perm'] = 'editable';

For multiple post types the edit_others_posts capability is ignored, for single post types it's checked and all posts are shown. I'm not sure whether it's by design to avoid overly complex SQL queries or an oversight.

[peterwilsoncc]

LGTM and tests well.

Thanks.

[peterwilsoncc]

E2E tests are failing on the main branch so bypassing the merge requirements.