Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set placeholder on the fly #213

Merged
merged 3 commits into from
Nov 1, 2024
Merged

set placeholder on the fly #213

merged 3 commits into from
Nov 1, 2024

Conversation

GuySerfaty
Copy link
Contributor

This PR adding the ability to change placeholder on runtime, took inspiration from:
ueberdosis/tiptap#1044 (comment)

@zzorba
Copy link

zzorba commented Oct 21, 2024

Thank you for the quick response on this, looking forward to trying it out.

@17Amir17 17Amir17 self-assigned this Oct 27, 2024
@17Amir17
Copy link
Collaborator

Sorry for the delay, will review tomorrow!

Copy link
Collaborator

@17Amir17 17Amir17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested lgtm

@17Amir17 17Amir17 merged commit 160add8 into main Nov 1, 2024
6 checks passed
@17Amir17 17Amir17 deleted the set-placeholder-on-the-fly branch November 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants