-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add ability to use custom flatlist implementation #173
base: main
Are you sure you want to change the base?
Conversation
f090fcf
to
dc181bd
Compare
updated patch version based on suggestion: #170 (comment) Please let me know if it is to be reverted If this patch version update is to be kept, this PR is to be merged after #172 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for the pr, however we found some issues that are blocking this
behavior={Platform.OS === 'ios' ? 'padding' : 'height'} | ||
style={exampleStyles.keyboardAvoidingView} | ||
> | ||
<Toolbar editor={editor} ListComponent={BottomSheetFlatList} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@17Amir17 I have updated the PR. You can re-review it.
iOS:
Screen.Recording.2024-08-01.at.00.11.29.mov
Android:
Screen.Recording.2024-08-01.at.00.12.12.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating - unfortunately I still see a few issues
When testing I got a bunch of these warnings:
WARN [Reanimated] Tried to modify key `reduceMotion` of an object which has been already passed to a worklet. See
https://docs.swmansion.com/react-native-reanimated/docs/guides/troubleshooting#tried-to-modify-key-of-an-object-which-has-been-converted-to-a-shareable
for more details.
} from 'react-native'; | ||
import { RichText, Toolbar, useEditorBridge } from '@10play/tentap-editor'; | ||
|
||
const useKeyboard = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to import this from @10play/tentap-editor
return keyboardHeight; | ||
}; | ||
|
||
export const WithBottomSheet = ({}: NativeStackScreenProps<any, any, any>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still unable to scroll on Android - seems like the scroll is getting handled by the drawer
Add ability to use custom Flatlist as component with example
Before: Flatlist does not scroll when used inside bottomsheet
Screen.Recording.2024-07-27.at.22.31.55.mov
After: Using BottomSheetFlatlist which scrolls when used inside @gorhom/bottom-sheet
Screen.Recording.2024-07-27.at.22.32.16.mov