Reduce size of RoundChange messages
#98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the size of
RoundChangeconsensus messages, by setting the latest prepared proposal and latest prepared certificates fields to nil (meaning that the proposal is going to be built each time, instead of transmitting it over the network), because this resulted in messages that are even a couple of MBs in size, that has significant impact on the network.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Additional comments
Please post additional comments in this section if you have them, otherwise delete it