#63 - communities page revamp #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..Communities.js: - 'your communities' section - sorting button: a-z, z-a, block - communities as flip-cards - scrolling description on back of flip-card ..CommunityPreviewCreator.js: - no more than 1 card at a time - integrated VERC creator - celebratory text on token creation ..FlipCard.js: - new icon - send dynamic css width/height variables to parent element for optional use - return to front on window resize - some global css edits
pinkiebell
reviewed
Nov 25, 2021
|
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
| @@ -68,23 +114,43 @@ export default class HabitatCommunityPreviewCreator extends HTMLElement { | |||
| this._ctx.canvas.height = h; | |||
|
|
|||
| wrapListener(this.shadowRoot.querySelector('#create'), this.create.bind(this)); | |||
| wrapListener(this.shadowRoot.querySelector('#boxleg'), () => { | |||
| //flip "create [community]" button to active / inverted color | |||
| this.parentElement.parentElement.parentElement.querySelector('#create-community').classList.toggle('active'); | |||
There was a problem hiding this comment.
A special CSS variable should be used to change visibility. Otherwise this throws If the layout of the dom changes or this element will be used somewhere else.
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
web/lib/HabitatCommunities.js
Outdated
| } | ||
|
|
||
| _userLoad (callback) { | ||
| async function _check () { |
There was a problem hiding this comment.
this check can be moved to chainUpdateCallback/render together w/ walletIsConnected
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
pinkiebell
reviewed
Nov 25, 2021
web/lib/HabitatCommunities.js
Outdated
| async render () { | ||
| const { habitat } = await getProviders(); | ||
|
|
||
| if (walletIsConnected()) { |
There was a problem hiding this comment.
should be moved to onChainUpdate.
I also not sure if we should hide it by default, this could confuse users looking for a button :)
There was a problem hiding this comment.
- missing "create" button in the overview page @MaxKaay
I'm thinking - show "create" button by default & prompt user with wallet connection upon pressing, if they aren't connected
There was a problem hiding this comment.
where is onChainUpdate? Should I add to HabitatCommunities.js, edit in HabitatPanel.js, rollup.js, or something else?
I believe this is the final task I have to complete.
There was a problem hiding this comment.
Sorry, its called chainUpdateCallback in this context
HabitatCommunities.js: - added ghost communities to avoid awkward flex behavior of single-card rows - moved flipcard 'window resize' eventlistener to HabitatCommunities.js as delegated eventlistener - moved portion of render() function to chainUpdateCallback -- called twice in render() to 1) load create button functions immediately, and 2) render all user communities -- looking for a fix (onChainUpdate?) HabitatCommunityPreviewCreator.js: - removed 'create token' event listener after token creation / celebration.
- create button handler moved to constructor - default sorting set
Communities.js: - set default sorting and call this.sort() in constructor - use MutationObserver on creatingCommunity container instead of reaching up DOM tree from CommunityPreviewCreator to invert button color. CommunityPreviewCreator.js: - remove classlist toggle that reaches up DOM tree (see above) - add image scaler to fit image in canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..Communities.js:
..CommunityPreviewCreator.js:
..FlipCard.js:
new icon
send dynamic css width/height variables to parent element for optional use
return to front on window resize
some global css edits