Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winediscordipcbridge-steam.sh #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

malinkb
Copy link

@malinkb malinkb commented Jun 26, 2024

Added support for non-snap, non-flatpak-version of discord by adding temp path: /usr/bin/discord

Added support for non-snap, non-flatpak-version of discord by adding temp path: /usr/bin/discord
@0e4ef622
Copy link
Owner

What distro are you using? Does this actually fix the script for you? $TEMP_PATH/usr/bin/discord seems like a very nonstandard temp path.

@malinkb
Copy link
Author

malinkb commented Jun 26, 2024 via email

@0e4ef622
Copy link
Owner

That's the path to the discord binary, which shouldn't matter. What matters is the path to the IPC socket. I'm also on arch linux, and for me that path is /run/user/1000/discord-ipc-0.

@malinkb
Copy link
Author

malinkb commented Jun 26, 2024

That's the path to the discord binary, which shouldn't matter. What matters is the path to the IPC socket. I'm also on arch linux, and for me that path is /run/user/1000/discord-ipc-0.

You are right, The /run/user/1000/discord-ipc-0 is present for me as well.

Tried with and without the path to my discord binary and the invite function works regardless.
What I figured however is that others see the name of the game reported correctly regardless of including the path or not.

However, in discord in the list of Registred Games under Activity Settings, only when the discord binary path included, the name of the game is reported correctly at least for me.

Also thank you for making this great app <3

@0e4ef622
Copy link
Owner

0e4ef622 commented Jun 26, 2024

However, in discord in the list of Registred Games under Activity Settings, only when the discord binary path included, the name of the game is reported correctly at least for me.

That is... very interesting. The line you add has nothing to do with this and it shouldn't even affect the way the game is run since the script already finds /run/user/1000/discord-ipc-0. Could it just be coincidence? I believe the game name that discord sees depends on how early discord detects the game, so it's a coin toss between the correct name and something like "pv-bwrap" or "wine64-preloader". Can you try multiple times to confirm that there is actually a difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants