Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract whitelisted borrowers #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

captainrandom
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    It white lists borrows based on a list of addresses stored in a contract. This gets the abi from etherscan.

  • What is the current behavior? (You can also link to an open issue here)
    I don't think that there is one? Currently there is a static allowed list, but I'd like to make the borrow white list to be dynamic whenever someone updates the contract (without the need to update the signal).

  • What is the new behavior (if this is a feature change)?
    Gets the whitellisted borrower addresses from the smart contract and checks if the provided borrower address is in the set.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

It shouldn't.

  • Other information:

@height
Copy link

height bot commented Feb 28, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@captainrandom captainrandom changed the base branch from develop to main February 28, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant