Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add appveyor ci with multi-targeting project #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanabi1224
Copy link

@hanabi1224 hanabi1224 commented May 22, 2019

Portable libs will be added later if there're no concerns about using a single multi-targeting project.
ci build (from folk repo): https://ci.appveyor.com/project/hanabi1224/html-agility-pack/builds/24739600/artifacts

- path: '**\*.nupkg'
name: nupkg
- path: '**\*.snupkg'
name: snupkg
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'$(TargetFramework)' == 'netstandard1.6' or
'$(TargetFramework)' == 'netstandard2.0'
">
<PackageReference Include="System.Net.Http" Version="4.3.4" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These libraries all ship OOB with netstandard2.0. Adding a dependency on these for netstandard2.0 is not required, and will only make the dependency graph more complex. Would it be possible to remove the dependency on these for netstandard2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants