Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit access to specific CA or SSL cert #29

Open
belcloud opened this issue May 18, 2018 · 2 comments
Open

Limit access to specific CA or SSL cert #29

belcloud opened this issue May 18, 2018 · 2 comments

Comments

@belcloud
Copy link
Contributor

Hello

Would it be possible to add an option to drop the connection if the proxmox's ssl certificate is not a specific one or does not belong to a specific CA?
Because if it accepts proxmox's self-signed certificate, it will accept any certificate in the case of a mitm attack.

Thank you

@zzantares
Copy link
Owner

zzantares commented May 18, 2018

Mmm well, right now you can supply your own Http client instance to the Proxmox constructor as an extra parameter, but now I notice this feature is undocumented. But in theory you can make your own Guzzle client with the cert option set.

But yes, I think it could be added as a convenience (although I don't do PHP anymore), how would you think this should be handled?

@belcloud
Copy link
Contributor Author

belcloud commented May 19, 2018

If guzzle can handle such, i think it should force the connection to use a specific certificate when connecting to the host. The certificate could be added as a file or as string in PEM format. I would see no problem with using a single certificate on all the proxmox clusters.
Alternatively, add a new CA and invalidate all the system/predefined CAs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants